fix[nginx]: Make sure we trust the GCP IPs to get the real client IP#1595
Merged
fix[nginx]: Make sure we trust the GCP IPs to get the real client IP#1595
Conversation
glevco
previously approved these changes
Feb 10, 2026
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1595 +/- ##
==========================================
- Coverage 85.69% 85.67% -0.03%
==========================================
Files 441 441
Lines 33793 33793
Branches 5286 5286
==========================================
- Hits 28959 28952 -7
- Misses 3817 3822 +5
- Partials 1017 1019 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luislhl
force-pushed
the
fix/nginx/add-gcp-ips
branch
from
d1365be to
c26f2f2
Compare
glevco
approved these changes
Feb 11, 2026
|
Bencher Report| Branch | fix/nginx/add-gcp-ips |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.43 m(-16.61%)Baseline: 1.71 m | 1.54 m (107.93%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1.43 m(-16.61%)Baseline: 1.71 m | 1.54 m (107.93%) | 2.06 m (69.49%) |
jansegre
approved these changes
Feb 12, 2026
luislhl
force-pushed
the
fix/nginx/add-gcp-ips
branch
from
c26f2f2 to
071f209
Compare
r4mmer
added a commit
that referenced
this pull request
Feb 24, 2026
…print-move-1 * origin/master: feat: pydantic settings (#1600) fix[thin_wallet]: handle address history invalid tx version (#1590) refactor(nano): Make NCBlockExecutor a pure executor with no side effects fix[nginx]: Make sure we trust the GCP IPs to get the real client IP (#1595) refactor: Upgrade to Pydantic v2 chore(github): Split GitHub main action into lint, test-cli, test-lib, test-other fix[nginx]: Use a larger buffer size for /v1a/status (#1594) chore: adjust testnet config for v0.69.0 release chore[storage]: Limit the total size of RocksDB WAL files (#1518) chore: adjust testnet config for v0.69.0 release chore: configure feature activations for v0.69.0 release refactor: wallet on_new_tx (#1561) refactor(nano): Remove dead reorg cleanup code from block executor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our Nginx config lacked a config to trust IPs from GCP and from GCP LBs
Acceptance Criteria
TODO
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged